Not sure why you had to do the inverted predicate check again in your first example. You already have the information encoded in the value of retval. It can be written like this:
int result = 0;
if(!p1)result = -ERROR1;
if(p2)result = -ERROR2;
if(!p3 && p4)result = -ERROR3;
if(result != 0) {
result = 42;
}
returnresult;
With a return value you have to add 4 extra lines. This overhead remains constant as you add more checks and more business logic.
Yes all the other suggestions are better than early returns in business logic and would help with leaks. Would be nice if we had RAII outside of C++. I think Rust has it? Haven’t done Rust yet.
Not sure why you had to do the inverted predicate check again in your first example. You already have the information encoded in the value of retval. It can be written like this:
int result = 0; if (!p1) result = -ERROR1; if (p2) result = -ERROR2; if (!p3 && p4) result = -ERROR3; if (result != 0) { result = 42; } return result;With a return value you have to add 4 extra lines. This overhead remains constant as you add more checks and more business logic.
Yes all the other suggestions are better than early returns in business logic and would help with leaks. Would be nice if we had RAII outside of C++. I think Rust has it? Haven’t done Rust yet.